There’s a related bug that I’ve previously raised. In the same circumstances, before the regression, the rename left the folder.jpg outside of the album folder created.
Problem with folder.jpg not in album folder
I’ve now released SongKong 11.1.1 with fix for the “java.nio.file.Path.getParent()” on Windows, Linux and Docker (not yet availble for MacOS so not posted update on forum yet), so please download and retry.
I vaguely remember the other issue (which is not really related) but I thought that was resolved so please retry with new version to see if problem still exists and if it does give me some more info.
I can confirm the regression is fixed but not the folder.jpg issue (try just 1 album).
Can you explain the folder.jpg further i dont really understand the issue.
Sure. Rename creates the album cover (folder.jpg), but instead of putting it in the album folder created, it’s put in the base folder. The base folder therefore includes a folder for the album and folder.jpg. This only happens if the repaired tracks are in the base folder. I haven’t tested with more than one album.
Beforer rename is run is there a folder.jpg in the base folder ?
After rename is run:
- is the track moved to a subfolder representing an album folder
- is there a folder.jpg in the album folder as as well
No
Yes
No
All tracks are moved to the album’s subfolder.
Hmm, I think the answer to first question is Yes.
If when run Fix Songs you have Save front cover to Filesystem enabled on saving each file if it has front conver art it will save that in the parent folder of the filename, i.e it makes the assumption that files are stored in an album folder.
So we could do an addtional check and not write to parent folder if it doesnt match the name of the album, but then we have issues if the folder does represent an album but is not exaclty the same as the album metadata value.
If we did do this that would prevent folder.jpg being created but would also mean one is not created at all in subfolder folder, since creating folder.jpgs is not part of the Rename Folder task.
Thoughts?
The answer to the first question is a definite ‘no’. Edit: upon reflection, I will check it’s not placed in the base folder when fixing songs.
Once upon a time, SK never had this issue.
OK I see the folder.jpg is placed in the base folder when fixing songs. So SK would ordinarily place it in the album folder, but that is not present in my case.
I placed tracks for 2 albums in the base folder without any album folders. SK created a folder.jpg for just one and placed it outside the 2 album folders created.
I tested again by putting all tracks (for the 2 albums) in a “New Folder” located in the base folder. This time the folder.jpg got placed in both of the newly created album folders (replacing “new folder”), but they were duplicates, i.e. only the cover of 1 of the albums.