Is it possible to add a SongKong checkbox to enable stop processing on error, though to still output error logs/reports?
Or is this option there and I missed it?
Thanks!
SK Option to Stop on Error?
There is currently no such option, can you give me a scenario where you think it is neccessary
Hello Paul,
The reason I was asking about an option to stop on error is that I received another org.hibernate error. Additionally, I’m having another error, that I believe is happening with SongKong but I haven’t been able to reproduce consistently.
Essentially with this other error I will get some duplicate audio files that are being renamed by the move option to a different track title and number on the same album. I still have to investigate but have some example files if they are of use to you.
These hibernate errors should not occur, in general if there is a severe error that breaks processing SongKong does stop. But if SongKong just has a problem particular to a file such as as it being read only it continues, I’m still not really convinced it would be helpful for SongKong to stop for that sort of reason.
Because these are duplicate songs they can get stripped from the folder to allow one copy of each song to be matched to album, then these duplicates are matched as single songs
Looking at your samples these are songs whose acoustid matches multiple recordings by different artists. You can see this by opening the songs in Jaikoz, selecting a song and choosing the ‘View Online/View this Acoustid at Acoustid’. You’ll see in each case both the correct song and the incorrectly matched songs are listed.
However in the absence of any metadata SongKong should pick the song with the most sources and in this test sample the song with the most sources is always the best one. So if your songs contained either no metadata or correct metadata to start with SongKong should have matched to the correct song not the incorrect one
I’ve spent some time testing and if I just rematch the song as provided they continue to match the wrong songs because they are using the incorrect metadata to decide on which recording to use. But if I delete all metadata with Jaikoz and then move the songs to a new folder (so that songkong does not derive metadata from foldername) and rematch all songs match to the correct song.
I’ve checked other code as well and I think that whatever bug caused the songs to be matched to the wrong song is now fixed. But I can see it is cumbersome to remove metadata when need to match songs just by acoustid so Ive raised http://jthink.net:8081/browse/SONGKONG-695 to consider adding a new option.
Seems like what he is asking would be more along the lines of a debug option. Something like that is typically hidden away in the documentation, like a line argument, such as “songkong.exe -debug” that would only be enabled or used for testing or troubleshooting.
It is best not to have songkong stop on errors, as a lot of people like the nature of run it and leave it. Nothing more annoying than starting it up on a large batch of files to run over night just to find out the next morning that it had stopped processing somewhere up front because of a minor error.